fix(rpc): handle properly action form#309
Open
arnaud-moncel wants to merge 2 commits into
Open
Conversation
2 new issues
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
|
|
||
| def initialize(scope:, form: nil, is_generate_file: false, description: nil, submit_button_label: nil, &execute) | ||
| # rubocop:disable Metrics/ParameterLists | ||
| def initialize(scope:, form: nil, is_generate_file: false, description: nil, |
| next if relation_targets_rpc_collection?(field) | ||
|
|
||
| relations[field_name] = field | ||
| end |
matthv
reviewed
May 21, 2026
| is_generate_file: action[:is_generate_file], | ||
| description: action[:description], | ||
| submit_button_label: action[:submit_button_label], | ||
| static_form: action[:static_form], |
Member
There was a problem hiding this comment.
WDYT action[:static_form] || false to avoid @static_form = nil when the key is missing ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definition of Done
General
Security
Note
Fix RPC schema to include
static_formin serialized actionsstatic_formto the RPC wire schema by including it inserialize_actions, alongsidescope,is_generate_file,description, andsubmit_button_label;formandexecuteare explicitly excluded.BaseAction.initializeto accept astatic_formparameter (default:false) and passes it through fromfrom_plain_object, so the value from the schema is preserved on the instance.build_rpc_schema_from_datasourcein agent.rb into smaller helpers (extract_rpc_collection_relations,build_normal_collection_payload,serialize_actions) to cleanly separate schema-building concerns.Macroscope summarized aedfadb.